Use async features in example generator - #88
Conversation
|
@bajtos Review please. |
There was a problem hiding this comment.
Will this exit the process with a non-zero status code when the import fails?
There was a problem hiding this comment.
Yes, as long as err is returned in the callback (we throw by default in strongloop/loopback-workspace@223758f#diff-383e9ce062435fb34a4326cdf175c907R16 causing an unhandledException event causing Node to return 1 for the exit code). I did a smoke test by changing the name of the JSON file in import.js deliberately causing a missing file error then checking the exit status in bash via echo $? which returned 1.
296406d to
3d2a1f3
Compare
|
@bajtos Review please. |
|
The code LGTM. Please update the commit message before landing, "Replace |
|
TY, commit message removed. |
3d2a1f3 to
be69bbd
Compare
|
Cool, please land the patch yourself. Do you have permissions to publish a new version to npmjs.org? Does this depend on a new version of loopback-workspace (see strongloop/loopback-workspace#172)? In that case we should bump up the minimum required version in package.json too. |
|
TY, yes I have publish permissions. I will bump the strongloop/loopback-workspace version and merge accordingly. |
- Change `app.importing` to `app.booting` - Use callbacks instead of emitting `import done`
be69bbd to
a21f613
Compare
Use async features in example generator
2 participants
app.importingtoapp.bootingimport doneimport doneevent with thereadyeventConnected to #74